Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom GetCPUQuantity and GetMemoryQuantity func #396

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review December 6, 2023 06:22
@luomingmeng luomingmeng force-pushed the dev/support_custom_get_resource_quantity branch from 349cba5 to 3e37853 Compare December 6, 2023 06:45
@luomingmeng luomingmeng force-pushed the dev/support_custom_get_resource_quantity branch from 3e37853 to a1f4329 Compare December 6, 2023 06:46
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (ff9c467) 53.65% compared to head (a1f4329) 53.56%.

Files Patch % Lines
pkg/util/native/resources.go 25.00% 26 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 1 Missing ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 0.00% 1 Missing ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   53.65%   53.56%   -0.10%     
==========================================
  Files         445      445              
  Lines       49020    49040      +20     
==========================================
- Hits        26304    26266      -38     
- Misses      19744    19812      +68     
+ Partials     2972     2962      -10     
Flag Coverage Δ
unittest 53.56% <30.23%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit af858f2 into kubewharf:main Dec 6, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants